search

os-autoinst / openQA

openQA web-frontend, scheduler and tools.
http://openqa.opensuse.org/
GNU General Public License v2.0
321 stars 208 forks source link

Remove tour to drop problematic dependency #5861

Closed Martchus closed 2 months ago

Martchus commented 2 months ago

See particular commit messages and https://progress.opensuse.org/issues/163004

I recommend to look at the individual commits.

github-actions[bot] commented 2 months ago

Great PR! Please pay attention to the following items before merging:

Files matching assets/stylesheets/**:

This is an automatically generated QA checklist based on modified files.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.51%. Comparing base (25dc7a3) to head (2560464). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5861 +/- ## ========================================== - Coverage 98.51% 98.51% -0.01% ========================================== Files 395 394 -1 Lines 38782 38730 -52 ========================================== - Hits 38205 38153 -52 Misses 577 577 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Martchus commented 2 months ago

So I don't misunderstand this again: What do you mean with "boostrap hint" and "first steps"?

Note that the tour so far just explained some UI elements that are in my opinion rather self-explanatory - especially with the newly added tooltips. It did not tell one first steps (like what we have in the "Getting started" documentation). The tour was also in general not about first steps but to notify users about new features (except that actually extending the tour was not really feasible in most cases and if we would have done it consequently we would now have a tour that is way to lengthy to click though from the beginning).

Martchus commented 2 months ago

Just to be sure, it is expected this should not even break openQA-in-openQA tests because we are not testing the tour, right?

It may break these tests because we probably dismiss the tour at some point.

Martchus commented 2 months ago

After @okurz 's last comment I hope we have found an agreement. So please re-review my latest changes.