os-autoinst / openqa-mon

Collection of terminal monitoring utilities for openQA
12 stars 13 forks source link

Add pagination on TUI #157

Closed ilmanzo closed 3 months ago

ilmanzo commented 3 months ago

Fixes #106

grisu48 commented 3 months ago

There are 2 visual issues that still need to be resolved:

image image

ilmanzo commented 3 months ago

should be better now:

https://github.com/user-attachments/assets/c7d98c4d-8a55-4acf-a2cc-545310e53c7e

grisu48 commented 3 months ago

should be better now: Screencast.from.2024-08-19.15-24-42.mp4

I still don't see any differences, but the last state is from an hour ago. Perhaps the last changes haven't been pushed yet?

ilmanzo commented 3 months ago

should be better now: Screencast.from.2024-08-19.15-24-42.mp4

I still don't see any differences, but the last state is from an hour ago. Perhaps the last changes haven't been pushed yet?

sorry, you're right.. Forgot to push :)

ilmanzo commented 3 months ago

Two minor comments, otherwise LGTM!

It looks great now 🙂

Actually your suggestion is a very good idea; I also got rid of the now useless offset :)

ilmanzo commented 3 months ago

how about a minor version bump ? I like 1.2.3 :D

grisu48 commented 3 months ago

how about a minor version bump ? I like 1.2.3 :D

Yes indeed. But I do version bumps in dedicated merge requests before a new release. This change would motivate one though.

grisu48 commented 3 months ago

Thank you for adding pagination support in openqa-mon @ilmanzo :partying_face: