os-climate / ITR

This Python module implements the ITR methodology.
Apache License 2.0
12 stars 9 forks source link

need better documentation and implementation of 'report_date' in template #46

Open MichaelTiemannOSC opened 2 years ago

MichaelTiemannOSC commented 2 years ago

Currently the tool uses report_date both as a label for the date of the fundamental financial data (which changes by the second when markets are open and is archived by the day in terms of high/low/open/close), and also as an indicator of the last year of valid climate data. Instead we should derive the last year of valid data by simply what's available and recognizing the last year.

MichaelTiemannOSC commented 2 years ago

This (with some more test cases) should close: https://github.com/os-climate/ITR/commit/e57af8788f511f3a0cdf07be96e9639dad2e4d70

Handing off to @khumbaeli5 if he wants to write some tests.