search

os-climate / corporate-data-pipeline-notebook

Repository for building a corporate data pipeline jupyter notebook, using aicoe-ci build pipeline
GNU General Public License v3.0
1 stars 6 forks source link

Update CONTRIBUTING.md #18

Open MichaelTiemannOSC opened 2 years ago

MichaelTiemannOSC commented 2 years ago

Add documentation link to https://gist.github.com/Chaser324/ce0505fbed06b947d962

Signed-off-by: MichaelTiemannOSC mtiemann@os-climate.org

Related Issues and Dependencies

N/A

This introduces a breaking change

This Pull Request implements

Documentation improvements for new contributors.

Description

MichaelTiemannOSC commented 2 years ago

I will note that following all of the instructions I could to the letter--including adding DCO signoff text as the last line of my actual commit (which was translated to a Pull Request with the signoff above the pull request details) resulted in an unacceptable PR due to DCO failure. I was able to follow the additional steps to producing a legitimate signoff, but...IT IS ABSOLUTELY ABSURD THAT IT IS SO DIFFICULT TO GET A CORRECT RESULT BY MERELY FOLLOWING INSTRUCTIONS.

This suggests we need to write our own gist, inserting instructions as to how it might be possible to issue a set of commands from the command line that does not fall all over itself the instant one attempts to push changes up to github.

@rynofinn @MightyNerdEric @grigarr @HeatherAck

MichaelTiemannOSC commented 2 years ago

And while we are fixing our interactions with the robots, we likely also need to fix the robots themselves to provide additional guidance on how to properly squash DCO-correcting cleanups, so that contributors are not faced with the double-jeopardy of having done all the DCO work only to have changes rejected because they are not squashed.