os-climate / hazard

Onboarding, creation and transformation of climate hazard models for OS-Climate
Apache License 2.0
6 stars 13 forks source link

Handle AWS authentication the standard way #62

Closed emileten closed 5 months ago

emileten commented 5 months ago

This repository is defining custom environment variables for AWS authentication https://github.com/os-climate/hazard/blob/762fc463629e6b51610211e47b7d1d5879bb7ab5/src/hazard/docs_store.py#L32.

We should remove all AWS credentials configuration concerns from this code, since the libraries we're using, e.g. s3fs, are able to detect credentials defined the standard way.

emileten commented 5 months ago

Instead of removing this behavior, I made it optional. If no such variables are in the environment, the system falls back to the standards.