search

os-climate / physrisk-ui

UI for the Physical Risk tool
Apache License 2.0
5 stars 10 forks source link

Add auto format tools #46

Closed deepanshu44 closed 2 years ago

deepanshu44 commented 2 years ago

Fixes #45

negillett commented 2 years ago

So, we run these tools with npm run format command?

deepanshu44 commented 2 years ago

Hello @negillett , yes, you can run this script after you make changes to a file.

But I believe most code editors provides users with automated tools which will use these configuration files to show errors and indent code on the fly.

@joemoorhouse in his comment also mentioned that-

We can then run that locally via command line and in Actions (presumably we also want to add to IDE).

deepanshu44 commented 2 years ago

@negillett One more thing, I haven't included much details about what and why I made some changes. I thought I should ask first whether or not should I include nitty gritty details in PR comment box. I think it would be better to provide details on how to configure init files for future self.

negillett commented 2 years ago

All good, @deepanshu44! The commit titles are pretty explainitive anyway. Maybe just resist squashing so they're preserved.