Hello @joemoorhouse, my changes for the generic score based measures:
Add bounds, definitions and descriptions for Hail, Drought, Fire, Precipitation and ChronicHeat to genereric_risk_model
Add mock for each hazards in risk_models_test module
=> I've changed the heat indicator_id in sp_heat so that it matches the one from Jupiter (days/above/5cm). This led to an error in the test_risk_indicator_model as we are testing measure for ChronicHeat for which indicator_id should be "mean_degree_days/above/index". There is no result so we get a -1 for the asset_score which doesn't match any value in the ScoreBasedRiskMeasureDefinition. This raised a StopIteration error in the get_score_details method. Should we add a default value to the next() function or is this not useful ?
Hello @joemoorhouse, my changes for the generic score based measures:
Add bounds, definitions and descriptions for Hail, Drought, Fire, Precipitation and ChronicHeat to genereric_risk_model
Add mock for each hazards in risk_models_test module => I've changed the heat indicator_id in sp_heat so that it matches the one from Jupiter (days/above/5cm). This led to an error in the test_risk_indicator_model as we are testing measure for ChronicHeat for which indicator_id should be "mean_degree_days/above/index". There is no result so we get a -1 for the asset_score which doesn't match any value in the ScoreBasedRiskMeasureDefinition. This raised a StopIteration error in the get_score_details method. Should we add a default value to the next() function or is this not useful ?
Thanks !