os-js / OS.js

OS.js - JavaScript Web Desktop Platform
https://www.os-js.org/
Other
6.87k stars 813 forks source link

[Applications] Settings - Rewrite #480

Closed andersevenrud closed 7 years ago

andersevenrud commented 7 years ago

The Settings application is something that has not changed much since the start of all of this. It's time to make it better.

One of the reasons is that I really want "pluggable" modules so it becomes easier to actually add/modify stuff.

I'm thinking something like the Gnome control panel thing.

Base:

Modules:

New stuff:

branch: https://github.com/os-js/OS.js/tree/development

branch: https://github.com/os-js/OS.js/tree/issue480

marktopper commented 7 years ago

How about something like this, including an option to add (or remove) setting groups.

image

So then an application can put it's own settings in there.

andersevenrud commented 7 years ago

@marktopper Yeah. something like that!

andersevenrud commented 7 years ago

@marktopper It will be something among those lines, yes :) An early prototype:

settings

marktopper commented 7 years ago

@anderssevenrud: Look good, keep on the good work.

How will it look once you go into a setting group? Have you decided that yet?

andersevenrud commented 7 years ago

@marktopper For now it will only be a "Save" and "Cancel" type button to bring you back. If you have any thoughts, please let me know.

andersevenrud commented 7 years ago

Another update settings2

marktopper commented 7 years ago

I don't think that there is a correct way to do for all of them since the content of them would be different.

Like those (taken from my Macbook Pro)

Desktop Settings (Select background and such)

skaermbillede 2016-09-21 kl 11 27 22

General Settings (Here OS.js could have general settings, like Show File Extensions and Sounds)

skaermbillede 2016-09-21 kl 11 27 55

Language and Locales (Select Language)

skaermbillede 2016-09-21 kl 11 28 08
andersevenrud commented 7 years ago

@marktopper For now it looks like this. Luckily it's very easy to modify.

settings3

marktopper commented 7 years ago

@andersevenrud: It's gonna be nice.

andersevenrud commented 7 years ago

This is now more or less done and ready for usage :)

You can check it out with the developer branch

andersevenrud commented 7 years ago

Well.... I'm calling this done for now and closing this issus. The remainding tasks already have individual issues.

Will merge into master as soon as it has been tested extensively :)