search

os-js / osjs-client

OS.js Client Module
https://manual.os-js.org/
Other
31 stars 31 forks source link

Configuration option to override window defaults in applications #115

Closed elixx closed 4 years ago

elixx commented 4 years ago

It would be nice to, for example, be able to customize the window size of the Xterm application.

We may have chatted about this ;) Ref: https://gitter.im/os-js/OS.js?at=5ed17522225dc25f54b450ed

andersevenrud commented 4 years ago

I started messing around with some other stuff, and bedtime suddenly turned into codetime :joy:

So, I opened a PR (https://github.com/os-js/osjs-client/pull/116) that implements this. I'll give it a few more hands on tests before merging, but I'm pretty confident that my unit tests covers it al (if you ignore the failed checks in the PR that is... seems like I have to update some deps for Github Actions to pass).

If you're feeling adventorius you could always try to switch out @osjs/client in your distro with a local branch of these changes ;)

andersevenrud commented 4 years ago

Just a small side-note for these changes. If you reload a session (restore application state), this will not take effect.

If Xterm windows was restored, you'll have to close all windows, then launch the application again, and it should work :)

andersevenrud commented 4 years ago

I just released a new version of @osjs/client with these changes :)