Added support for labels and translated application titles on shortcuts.

os-js / osjs-client

OS.js Client Module

https://manual.os-js.org/

Other

30 stars 30 forks source link

Closed bthaase closed 2 years ago

bthaase commented 2 years ago

Formerly used 'label' property in shortcuts.json is utilized to override shortcut display name. Failback to filename as before.
On shortcuts with the 'osjs/application' mime type and no label, the translated application title is used.

andersevenrud commented 2 years ago

Nevermind the failing tests. I pushed some changes to take care of those, and your next commit should re-trigger and succeed.

bthaase commented 2 years ago

Perfect, soon as I get my head around this rebase i'll recommit, lol.

bthaase commented 2 years ago

Making one more pass, I forgot to check mime, no reason to ping the package manager for misc files.

bthaase commented 2 years ago

Making one more pass, I forgot to check mime

I missed this. Setting back to requested state. Sorry for the noise!

Oops, you're right, I added a fix then switched out the code and forgot it again! 😭

andersevenrud commented 2 years ago

Thanks for the contribution! Your implementatation is quite better than my final suggestion :100: