search

os-js / osjs-client

OS.js Client Module
https://manual.os-js.org/
Other
30 stars 30 forks source link

bad location of search box in rtl languages #200

Closed mahsashadi closed 1 year ago

mahsashadi commented 1 year ago

Search box is positioned badly when locale is set to Persian. Screenshot from 2022-12-12 09-46-38

mahsashadi commented 1 year ago

I have fixed this issue by adding this style:

.osjs-root[data-locale='fa_FA'] {

  .osjs-search{
    direction: ltr;
  }

  .osjs-search *{
    direction: rtl;
  }
 }

How can I fix that in your repo?

andersevenrud commented 1 year ago

You can use .osjs-root[data-dir="rtl"] {} to apply for all rtl languages.

Search styles are defined here: https://github.com/os-js/osjs-client/blob/a777f29e2a3b23eef6c354c8ba106777225fe1e1/src/styles/_search.scss

mahsashadi commented 1 year ago

Search styles are defined here: https://github.com/os-js/osjs-client/blob/a777f29e2a3b23eef6c354c8ba106777225fe1e1/src/styles/_search.scss

@andersevenrud So does it need to have a PR in this file? or just considert it in my own repo?

andersevenrud commented 1 year ago

If it fixes an issue that's upstream you're welcome to open a PR.