Closed mahdi00021 closed 1 year ago
@andersevenrud thanks for merge
Thanks for the contribution.
There was some styling issues in the test file, but I just followed this up myself: https://github.com/os-js/osjs-client/commit/decda8d44a023359e1759c42be7523dc6df5f6d3
Thanks for the contribution.
There was some styling issues in the test file, but I just followed this up myself: decda8d
Because ESLint fixes the src folder, I did not apply it to the test file
Because ESLint fixes the src folder, I did not apply it to the test file
And I've since fixed this.
However, since it didn't test the tests folder it does not mean it does not apply there. Use your best judgement (I've also commented quite a few times about this, i.e: about correct indentation and such -- which you can do with your eyes. No need for eslint) :)
Because ESLint fixes the src folder, I did not apply it to the test file
And I've since fixed this.
However, since it didn't test the tests folder it does not mean it does not apply there. Use your best judgement (I've also commented quite a few times about this, i.e: about correct indentation and such -- which you can do with your eyes. No need for eslint) :)
.
Because ESLint fixes the src folder, I did not apply it to the test file
And I've since fixed this.
However, since it didn't test the tests folder it does not mean it does not apply there. Use your best judgement (I've also commented quite a few times about this, i.e: about correct indentation and such -- which you can do with your eyes. No need for eslint) :)
I set the indentation manually once, for other files your friend complained why the file changed :))
I set the indentation manually once, for other files your friend complained why the file changed
It was not a complaint, just a mere suggestion for improvement or inquiry about a change. And it was not even related to this.
But it doesn't really matter now that it's been followed up manually, and I've enforced all style checks to run in the tests directory in any scenario.
I set the indentation manually once, for other files your friend complained why the file changed
It was not a complaint, just a mere suggestion for improvement or inquiry about a change. And it was not even related to this.
But it doesn't really matter now that it's been followed up manually, and I've enforced all style checks to run in the tests directory in any scenario.
No, I didn't say now. I before edited Indentations some files manually and push them. Your friend said why did you change the rest of the files?
I do not intend to argue and I did not say that there is hostility I mean Because you said that the indentation test file is not correct I said that if I want to modify it, your friend will probably tell you why the file was changed and I should have started from the
beginning, that's why I didn't edit the style files except for the src folder.
It was simply this:
package-lock.json
, which was an error by you@ajmeese7 is an official maintainer of this project. He just followed up with some reviews and general friendly and insightful comments on how to improve your contribution. There was no hostility or complaints.
In fact, none of the discussions had have been complaints. Just a part of a review process where the goal is to have a friendly talk about how to get the best result possible.
I'm locking this PR now because this is now an off-topic discussion.
please check PR
Ref: #204 #202 #201 #199