Window resized event contains undefined parameters on mazimize/restore - Githubissues

os-js / osjs-client

OS.js Client Module

https://manual.os-js.org/

Other

31 stars 31 forks source link

Window resized event contains undefined parameters on mazimize/restore #77

Closed josephjeno closed 4 years ago

josephjeno commented 4 years ago

The resized event that fires after a window is maximized or minimized should contain the updated window dimensions. Currently the event parameters are undefined. Thanks my dude!

andersevenrud commented 4 years ago

Why do you need this for the minimize event ? The windows does not physically change dimensions at this point :thinking:

josephjeno commented 4 years ago

Ah right you are. Correction - the restore("un-maximize") event.

andersevenrud commented 4 years ago

Gotcha!

andersevenrud commented 4 years ago

Opened a PR for this that I'll deploy now: https://github.com/os-js/osjs-client/pull/78

andersevenrud commented 4 years ago

I published @osjs/client@3.1.8 . Let me know how it works out :blush:

josephjeno commented 4 years ago

Works like a charm!

andersevenrud commented 4 years ago

Great!