os-js / osjs-client

OS.js Client Module
https://manual.os-js.org/
Other
31 stars 31 forks source link

Add setting in config.js to disable leftctrl to move #81

Closed josephjeno closed 4 years ago

josephjeno commented 4 years ago

We use leftctrl in some of our apps, which are conflicting with the osjs leftctrl behavior. Thanks!

andersevenrud commented 4 years ago

On it!

andersevenrud commented 4 years ago

PR incoming :)

https://github.com/os-js/osjs-client/pull/82

andersevenrud commented 4 years ago

I added this to the static global configuration for now, so you can do:

{
  windows: {
    moveKeybinding: false
  }
}

I might change this in the future to apply to the user settings instead, but if that's the case I'll notify here (and leave backward compability for a while).

andersevenrud commented 4 years ago

Update should be out.

Run npm update @osjs/client and npm run build and let me know how it works out :)

andersevenrud commented 4 years ago

(in case you read notifications by email, I edited my second to last comment here about config, because I had a typo)

josephjeno commented 4 years ago

Works great, thanks Anders! @valp124 will be delighted.

andersevenrud commented 4 years ago

Glad to hear it :)