search

os-js / osjs-client

OS.js Client Module
https://manual.os-js.org/
Other
31 stars 31 forks source link

User group checking is too strict #85

Closed josephjeno closed 4 years ago

josephjeno commented 4 years ago

Currently if an application (or mountpoint) has multiple groups, ie ["admin", "webce"], the user must be a member of both groups in order for the application to be visible. I think the application should be visible if a user is a member of any one of the application groups.

andersevenrud commented 4 years ago

PR incoming: https://github.com/os-js/osjs-client/pull/86

andersevenrud commented 4 years ago

3.1.12 has now been released with these changes.

The following settings should resolve your issue:

{
  attributes: {
    strictGroups: false
  }
}
josephjeno commented 4 years ago

Thanks Anders, just checking that will also work if I plop it into the application metadata.json? Or only vfs mountpoints?

andersevenrud commented 4 years ago

VFS Mountpoints only.

josephjeno commented 4 years ago

Ah I see, is it possible to have a similar solution for applications? It exhibits the same strict group behavior by default as the vfs mountpoints.

andersevenrud commented 4 years ago

Looking at that now :)

andersevenrud commented 4 years ago

3.1.13 is now out, which supports the same property inside metadata.json :)

andersevenrud commented 4 years ago

(without the attributes ofc. Just straight into the root JSON object)

andersevenrud commented 4 years ago

Since you reported it works fine on the Gitter chat I'll be closing this one. Thanks!