search

os-js / osjs-client

OS.js Client Module
https://manual.os-js.org/
Other
31 stars 31 forks source link

Setting window size to 1.0 makes it 1px #87

Closed andersevenrud closed 4 years ago

andersevenrud commented 4 years ago

Anything below 1.0 works (ex 0.99), so this is just a simple condition calculation error.

andersevenrud commented 4 years ago

This is the culprit:

https://github.com/os-js/osjs-client/blob/master/src/utils/windows.js#L217

In isNumber's mind 1.0 is a round number, so it makes sense. Gotta add an extra check for this.

andersevenrud commented 4 years ago

This was fixed and released.