search

os-js / osjs-client

OS.js Client Module
https://manual.os-js.org/
Other
31 stars 31 forks source link

Add support for Persian/Farsi language #89

Closed msjavan closed 4 years ago

msjavan commented 4 years ago

@andersevenrud, I copy & paste the en_EN language file and do changes on it. what should I do for these reviews which are failed?

andersevenrud commented 4 years ago

Run npm run eslint to see any issues with your javascript

msjavan commented 4 years ago

npm run eslint on "/home/morteza/osjs/osjs-client/" output following errors:

/home/morteza/osjs/osjs-client/src/adapters/auth/localstorage.js 36:27 error 'core' is defined but never used no-unused-vars 36:33 error 'options' is defined but never used no-unused-vars

/home/morteza/osjs/osjs-client/src/adapters/auth/server.js 36:27 error 'options' is defined but never used no-unused-vars

/home/morteza/osjs/osjs-client/src/adapters/settings/localstorage.js 38:30 error 'core' is defined but never used no-unused-vars

/home/morteza/osjs/osjs-client/src/adapters/ui/iconview.js 116:14 error 'error' is defined but never used no-unused-vars 273:22 error 'files' is defined but never used no-unused-vars

/home/morteza/osjs/osjs-client/src/adapters/vfs/apps.js 40:23 error 'options' is defined but never used no-unused-vars ... ...

What is the problem? @andersevenrud

andersevenrud commented 4 years ago

I'm not sure why you see all of these messages. There should only be this one as reported here: https://travis-ci.org/os-js/osjs-client/builds/643750230#L247

Have you run npm install inside the osjs-client ?

msjavan commented 4 years ago

I have corrected styling error, what should I do with codeclimate for?

•• Timing: .engineConfig: 0.009s Error: Could not find "@osjs/stylelint-config". Do you need a configBasedir? See our documentation at https://docs.codeclimate.com/docs/stylelint for more information.

@andersevenrud

andersevenrud commented 4 years ago

You can't do anything with the CodeClimate errors. I'm waiting for answer from their support about this issue (i have it in multiple repos).

Edit: Here's a link https://github.com/gilbarbara/codeclimate-stylelint/issues/38

andersevenrud commented 4 years ago

Just in case you make any pull-requests in the future.

Make sure that you create a new git branch when you submit these.

In this case I squashed all of your commits so it only looks like one was made, meaning that you have to either reset your cloned repository to this one, or do a new clone.

andersevenrud commented 4 years ago

Also, thanks! :)

andersevenrud commented 4 years ago

I just published @osjs/client@3.1.9 with these changes.