search

os-js / osjs-dev-meta

OS.js Development Meta Package
3 stars 5 forks source link

Remove node-sass and replace with dart sass #10

Closed LordZardeck closed 3 years ago

LordZardeck commented 3 years ago

node-sass is deprecated and the project even says to migrate away from it. I tested on my own project, and simply replacing the dependency seems to work. The primary reason I needed this change was because node-sass doesn't seem to work on my M1 MacBook Pro, but dart sass does.

andersevenrud commented 3 years ago

It sure looks like sass-loader can handle dart sass as a drop-in replacement. Didn't know that :)

This is great, because about 50% of my support cases usually involves node-gyp issues on non-Linux platforms because there's no binaries shipped.

I will test around with this a little bit and get back to you ASAP. Thanks!

andersevenrud commented 3 years ago

This indeed seems to work just fine :)

andersevenrud commented 3 years ago

Released as @osjs/dev-meta@2.1.0.