search

os-js / osjs-dev-meta

OS.js Development Meta Package
3 stars 5 forks source link

Complex Webpack compiler destructuring #29

Closed ajmeese7 closed 2 years ago

ajmeese7 commented 2 years ago

Unfortunately the previous suggested method did not work, and the whole nested path to the desired properties was required.

andersevenrud commented 2 years ago

I assumed that the suggestion I made was just that and that the changes were tested and working :sweat_smile:

andersevenrud commented 2 years ago

Released as 2.3.1.

NB: Reworded your commit message a bit (with a typo even)

andersevenrud commented 2 years ago

I assumed

Which reminds me. Never assume that the stuff I put down in the reviews is actual working code. It's super easy to miss things on my end without having to check out the code physically, set up, etc, which makes reviews very hard work.

andersevenrud commented 2 years ago

I think maybe it would be valuable to set up some kind of CI here that could prevent any kind of accidents or unwanted breakage.

There's already example package templates for applications, but it could also be done for themes. So the Action would just

  1. Check out a template repo and change to that directory
  2. Run npm install
  3. Then npm install <path to where action checked out dev-meta source>
  4. Then npm run build
  5. Compare the metadata etc. to a valid set

This ties into https://github.com/os-js/OS.js/issues/784

:thinking:

andersevenrud commented 2 years ago

Related to the last comment, I went ahead and added a starter on this https://github.com/os-js/osjs-dev-meta/pull/30