search

os-js / osjs-gui

OS.js GUI Module
https://manual.os-js.org/v3/
Other
18 stars 10 forks source link

Added 'toggle' option to ContextMenu. #21

Closed corwin-of-amber closed 4 years ago

corwin-of-amber commented 4 years ago

Following the discussion at https://github.com/os-js/osjs-panels/pull/26.

corwin-of-amber commented 4 years ago

I remembered to run eslint on it this time 🤓

andersevenrud commented 4 years ago

I see that I have to update the eslint config a little bit :angel:

corwin-of-amber commented 4 years ago

Am I supposed to indicate to Github somehow after I've done a requested change? I thought resolving the conversation does it. But it still says "Changes requested."

andersevenrud commented 4 years ago

I think it just bugged. On my end it can't find some reference to a commit. And there's no UI button or anything that lets me say OK or anything :man_facepalming:

Which reminds me, you should probably make pull requests on custom branches, ex feature/contextmenu-toggle.

I might change some minor stuff or commit messages and the likes, so your master would not be up to sync with upstream properly in those cases.

corwin-of-amber commented 4 years ago

your master would not be up to sync with upstream properly in those cases.

Ah yes, good thinking 👍

corwin-of-amber commented 4 years ago

Yayyyyy

andersevenrud commented 4 years ago

Thanks! :ok_hand:

andersevenrud commented 4 years ago

FYI: I updated the @osjs/eslint-config rules so that it triggers on all of the code style changes I've been requesting :)

andersevenrud commented 4 years ago

I just published a new version of @osjs/gui with these changes.