os-js / osjs-gui

OS.js GUI Module
https://manual.os-js.org/v3/
Other
18 stars 10 forks source link

List don't render properly in Firefox #31

Closed miladhashemi closed 4 years ago

miladhashemi commented 4 years ago

Hi, In list view columns without values cause messing up . image

node v12.18.0 hyperapp v1.2.10 @osjs/gui v4.0.33

andersevenrud commented 4 years ago

What browser are you using ?

miladhashemi commented 4 years ago

What browser are you using ?

I'm using Mozilla firefox.

andersevenrud commented 4 years ago

Hm. I'm unable to reproduce this in the latest version of Firefox (nor any other browser).

There's actually a CSS rule that sets a minimum height to be the size of the base font, so technically this should not occur.

You can actually see this rule in action at the top row in your screenshot, which seems to be correctly aligned.

Have you always had this issue, or has it been introduced at some later point ?

andersevenrud commented 4 years ago

Hold on. I was actually testing the online demo and not a local distro. When I fired it up locally I can now see this.

Investegating.

andersevenrud commented 4 years ago

I've released a new version of @osjs/gui that should solve your problem. Update this package and re-build your client.

miladhashemi commented 4 years ago

I've released a new version of @osjs/gui that should solve your problem. Update this package and re-build your client.

Now it works properly.

andersevenrud commented 4 years ago

Great!