os-js / osjs-panels

OS.js Panels Module
https://manual.os-js.org/v3/
Other
4 stars 13 forks source link

Pinning applications to main menu #29

Closed msjavan closed 4 years ago

msjavan commented 4 years ago

having ability to add applications to main menu in addition to categories.


Edited by @andersevenrud

andersevenrud commented 4 years ago

Technically this should work, but I'm not sure about the best way to make it possible.

Right now a false-y category will make it default to "other" :thinking:

andersevenrud commented 4 years ago

I've started working on a possible solution for this: https://github.com/os-js/osjs-panels/pull/31

What did you have in mind when enabling applications to show up on the root ?

  1. Have it as a setting on the panel item (per application)
  2. Have it as a setting on the client (per application)
  3. Have it as a metadata entry
msjavan commented 4 years ago
  1. Have it as a metadata entry. For example if no category specified, goes to the root, or using an option to add favorite apps in the root.
andersevenrud commented 4 years ago

Here's the thing though. An application should define a category. It's not just for UI reasons.

As I said, it falls back to "other" when nothing is defined.

So I'm thinking option number 2:

{
  application: {
    pinned: ['FileManager']
  }
}
andersevenrud commented 4 years ago

Or, seeing down the road option 1 might be best -- because then users can for example open a dialog (or the settings app) to set what apps they want to pin themselves.

But this could be combined with 2 making it a global and per-user basis.

msjavan commented 4 years ago

I agree, It would be good to pin apps per-user basis.

andersevenrud commented 4 years ago

I've implemented option 2.

I need to finish panel item settings persistence before being able to work in option 1.

Edit - https://github.com/os-js/osjs-panels/issues/33

andersevenrud commented 4 years ago

I've just published @osjs/panels@3.0.21 that supports the following client option to pin applications globally:

{
  application: {
    pinned: ['FileManager']
  }
}
andersevenrud commented 4 years ago

@josephjeno You might have some use for this :)

josephjeno commented 4 years ago

@andersevenrud definitely!