search

os-js / osjs-server

OS.js Server Module
https://manual.os-js.org
Other
19 stars 21 forks source link

Fix annotation of VFS search function #70

Closed mahsashadi closed 1 year ago

mahsashadi commented 2 years ago

It seems search function does not return boolean.

andersevenrud commented 2 years ago

having an actual type

That would be preferable. I checked, and this package don't have many of them documented.

Also, a lot of the annotations in this file is invalid. Should actually be Promise<T> for pretty much all of them :sweat_smile:

andersevenrud commented 2 years ago

A good commit message for this would be: docs(vfs): update search function annotation.

This repo uses https://www.conventionalcommits.org/en/v1.0.0/

mahsashadi commented 1 year ago

A good commit message for this would be: docs(vfs): update search function annotation.

This repo uses https://www.conventionalcommits.org/en/v1.0.0/

Done @andersevenrud

andersevenrud commented 1 year ago

Done

Could you make it a Promise<Object> ?