search

os / slacker

Full-featured Python interface for the Slack API
Apache License 2.0
1.6k stars 245 forks source link

Specify required python versions a more travish way to make them work #122

Closed madmuffin1 closed 7 years ago

madmuffin1 commented 7 years ago

PR #118 and #120 failed on travis, simply because the python version under test was not available in the container.

This changes the behavior to have travis explicitly install the required version and pass that version by getting the TOXENV from an automatically set environment variable.

Daenyth commented 7 years ago

I've had good luck with https://pypi.python.org/pypi/tox-travis

madmuffin1 commented 7 years ago

@Daenyth I had a look into that and it seems to be looking it the same environment variable as my one line shell script. Might be more pythonic, but I like my snippet for its simplicity.

os commented 7 years ago

Nice! Thanks, @madmuffin1.