search

os / slacker

Full-featured Python interface for the Slack API
Apache License 2.0
1.6k stars 245 forks source link

Improving error display by including whole JSON message #124

Closed Lucas-C closed 6 years ago

Lucas-C commented 6 years ago

Currently, this is the kind of error you can see popping:

slacker.Error: missing_scope

With this patch, now you'll see:

slacker.Error: missing_scope: {"needed": "users:read", "provided": "admin,identify,channels:history"}
os commented 6 years ago

Hi @Lucas-C. Thanks for looking at it. We probably don't want to complicate the error value. All of this is already available in body field. I'm going to close this.

Lucas-C commented 6 years ago

This doesn't make the error more complicated IMHO, it only makes it more explicit and helpful.