POST api payloads in the request body, not url

os / slacker

Full-featured Python interface for the Slack API

Apache License 2.0

1.6k stars 245 forks source link

POST api payloads in the request body, not url #43

Closed terite closed 9 years ago

terite commented 9 years ago

Even though some methods are specifically set to make POST requests, they still send the message payload entirely in params like a GET request. The max length of a url is much lower than the 16K bytes that Slack accepts in request bodies.

I just did a search & replace for params= inside self.post calls. I've manually tested chat.post_message, but not other methods.

os commented 9 years ago

Thanks @terite. I'll look into that sometime this week.

os commented 9 years ago

Good catch! :clap: Thanks, @terite! All the API calls in the initial version were GET and then I decided to use the right method for each call but it looks like I missed all of these.