os / slacker

Full-featured Python interface for the Slack API
Apache License 2.0
1.6k stars 245 forks source link

should response.successful != True yield an exception? #68

Closed SoCalLongboard closed 7 years ago

SoCalLongboard commented 8 years ago

On lines 61-62 in slacker/init.py, you raise an exception where response.successful != True. In the WebAPI implementation, the response would simply be yielded with 'ok': 'False' and 'error': '[some error message]'. Wouldn't it make more sense to mimic the WebAPI implementation in this respect and just yield the response as-is? Thanks!

os commented 8 years ago

That was a design decision back then. I can't think of a scenario where this may cause issues with your integration. Can you give me an example?