os / slacker

Full-featured Python interface for the Slack API
Apache License 2.0
1.6k stars 245 forks source link

files.upload: file is not required if content specified #80

Closed thejuan closed 7 years ago

thejuan commented 8 years ago

file is currently required, but the API doesn't require it if content is specified.

os commented 8 years ago

Hmm... It used to be required. We need to think about backwards compatibility when we make this change. Any ideas?

thejuan commented 8 years ago

Make it optional in the parameter list (but it maintains its position) Then in code ensure that file or content is set.