Cannot build on Apple M1 - protocolbuffer

os72 / protoc-jar-maven-plugin

Protocol Buffers protobuf maven plugin - based on protoc-jar multi-platform executable protoc JAR

http://os72.github.io/protoc-jar-maven-plugin/

Apache License 2.0

252 stars 78 forks source link

Cannot build on Apple M1 - protocolbuffer #129

Open ravileeladhar2023 opened 2 years ago

ravileeladhar2023 commented 2 years ago

[INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 0.630 s [INFO] Finished at: 2022-10-04T15:10:04+02:00 [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal com.github.os72:protoc-jar-maven-plugin:3.11.4:run (generate-sources) on project fcpsinboundadapter: Error extracting protoc for version 3.11.4: Unsupported platform: protoc-3.11.4-osx-aarch_64.exe -> [Help 1]

o Reproduce

On a macOS machine with properties:

MacBook Pro (16-inch, 2021) Chip Apple M1 Pro

ennerf commented 1 year ago

Google started releasing the osx aarch64 version in 3.17.3.

For older versions like 3.11.4 you'd have to fall back to the x86_64 version using mvn <command> -Dos.arch=x64_64.

You can specify the version in the configuration

<configuration>
    <protocVersion>${protoc.version}</protocVersion>
</configuration>

spensonshih commented 5 months ago

@ravileeladhar2023, I encountered the same. Please checkout the fork: https://github.com/blackrock/protoc-jar-maven-plugin

This forked version uses Google’s Protoc version 3.25.1 by default which supports osx aarch64.

ennerf commented 5 months ago

@spensonshih Looking at your repo it looks like you (1) forked the project without the commit history, (2) changed all namespaces, (3) added BlackRock logos, and (4) removed all links to the original repo.

It looks like most of the code is straight up copied, but anyone looking at the repo will get the impression that you're the original authors. That is not cool.

spensonshih commented 5 months ago

@ennerf we considered this project as abandoned, and by taking over maintenance of the project, we had to put the repo under BlackRock namespace in order to publish to Maven Central.

Our README has clearly included credit to the original repo.

You’ll also notice this repo was original from another repo: https://github.com/igor-petruk/protobuf-maven-plugin

ennerf commented 5 months ago

edit: somehow I missed the link. It could be more obvious, but good luck 👍