osCommerce / oscommerce2

osCommerce Online Merchant v2.x
http://www.oscommerce.com
MIT License
281 stars 221 forks source link

Taxes not applying to taxable goods at checkout #520

Open scottcwilson opened 7 years ago

scottcwilson commented 7 years ago

Configuration is Display Prices with Tax = false, checking out with account in a zone subject to tax. Fresh install of current Github master.

haraldpdl commented 7 years ago

The tax is shown in the order total listing however not besides the products.

Line 146; if the if (sizeof($order->info['tax_groups']) > 1) statement is removed, the tax is shown however it shows 0% for products where tax is not applicable. Will be looked into further.

Assigning this to Gary 🍺

Gergely commented 7 years ago

[15-Jan-2017 11:40:25 Europe/Budapest] PHP Stack trace:

[15-Jan-2017 11:40:25 Europe/Budapest] PHP   1. {main}() catalog\address_book_process.php:0

[15-Jan-2017 11:40:25 Europe/Budapest] PHP   2. OSC\OM\DbStatement->valueInt() catalog\address_book_process.php:118

[15-Jan-2017 11:40:25 Europe/Budapest] PHP   3. OSC\OM\DbStatement->valueMixed() catalog\includes\OSC\OM\DbStatement.php:228

Need zone id save like this:

$zone_id = (int)$Qzone->result[0]['zone_id'];
Gergely commented 7 years ago
[15-Jan-2017 11:53:28 Europe/Budapest] PHP Notice:  Undefined index: zone_id in catalog\includes\OSC\OM\DbStatement.php on line 203

[15-Jan-2017 11:53:28 Europe/Budapest] PHP Stack trace:

[15-Jan-2017 11:53:28 Europe/Budapest] PHP   1. {main}() catalog\create_account.php:0

[15-Jan-2017 11:53:28 Europe/Budapest] PHP   2. OSC\OM\DbStatement->valueInt() catalog\create_account.php:152

[15-Jan-2017 11:53:28 Europe/Budapest] PHP   3. OSC\OM\DbStatement->valueMixed() catalog\includes\OSC\OM\DbStatement.php:228

https://github.com/Gergely/oscommerce2/tree/issue_520