search

osCommerce / oscommerce2

osCommerce Online Merchant v2.x
http://www.oscommerce.com
MIT License
281 stars 222 forks source link

Do not suppress errors in admin/includes/column_left.php #601

Open mgutt opened 6 years ago

mgutt commented 6 years ago

Regarding v2.3.4

This should not be suppressed: if ($dir = @dir(DIR_FS_ADMIN . 'includes/boxes')) {

Better: if ($dir = dir(DIR_FS_ADMIN . 'includes/boxes')) {

Reason: DIR_FS_DOCUMENT_ROOT was wrong, but I did not found this reason directly because of the suppressed error. This is the bug because DIR_FS_DOCUMENT_ROOT was wrong: https://github.com/osCommerce/oscommerce2/issues/600