osCommerce / oscommerce2

osCommerce Online Merchant v2.x
http://www.oscommerce.com
MIT License
281 stars 222 forks source link

2.4 Improve is_integer by is_int #610

Closed oitsuki closed 6 years ago

oitsuki commented 6 years ago

Int is_integer is an alias, better to use int for best performance; Just question ?

/OM/db.php

public static function getSchemaFromFile($file)

.... find this

              if (is_integer($is_binary)) {
                    array_splice($details, $is_binary, 1);
                    $schema['col'][$field_name]['binary'] = true;
                }

                $is_unsigned = array_search('unsigned', $details);

                if (is_integer($is_unsigned)) {
                    array_splice($details, $is_unsigned, 1);
                    $schema['col'][$field_name]['unsigned'] = true;
                }

replace by

              if (is_int($is_binary)) {
                    array_splice($details, $is_binary, 1);
                    $schema['col'][$field_name]['binary'] = true;
                }

                $is_unsigned = array_search('unsigned', $details);

                if (is_int($is_unsigned)) {
                    array_splice($details, $is_unsigned, 1);
                    $schema['col'][$field_name]['unsigned'] = true;
                }

              $is_auto_increment = array_search('auto_increment', $details);

                if (is_int($is_auto_increment)) {
                    array_splice($details, $is_auto_increment, 1);
                    $schema['col'][$field_name]['auto_increment'] = true;
                }

                if (!empty($details)) {
                    $schema['col'][$field_name]['other'] = implode(' ', $details);
                }
oitsuki commented 6 years ago

After vérification, there is a repercution on install process does'nt work. Forget