Stat pages dont use absolute rows - Githubissues

osCommerce / oscommerce2

osCommerce Online Merchant v2.x

http://www.oscommerce.com

MIT License

281 stars 222 forks source link

Stat pages dont use absolute rows #653

Open tgely opened 4 years ago

tgely commented 4 years ago

https://github.com/osCommerce/oscommerce2/blob/de0e97d15d43ac6a9a6cfb2847134a82a0148f2b/catalog/admin/stats_products_viewed.php#L38 relative rows looks like every product is ok on every page...

But it would be better if absolute rows applied instead:

  if (isset($_GET['page']) && ($_GET['page'] > 1)) {
    $rows = ((int)$_GET['page'] - 1) * MAX_DISPLAY_SEARCH_RESULTS;
  } else {
    $rows = 0;
  }