osCommerce / oscommerce2

osCommerce Online Merchant v2.x
http://www.oscommerce.com
MIT License
281 stars 222 forks source link

Username and password recheck bypassed #658

Closed peng-hui closed 1 year ago

peng-hui commented 4 years ago

Hi,

I just find that, in many places of oscommerce v2.3.4.1, the username and password recheck during registration and other processes can be bypassed easily through the magic string in loose comparison, for example "0e11111" == "0e22222" returns Bool(True). If the user sets the username or password to such magic strings, the recheck process using loose comparison (==) does not work at all. Affected code locations

and some other files in catalog/password_reset.php, catalog/create_account.php and catalog/ext/modules/content/account/set_password.php