search

osPlanning / omx

Open Matrix (OMX)
https://github.com/osPlanning/omx/wiki
Apache License 2.0
50 stars 18 forks source link

Make a release of Python-OMX #13

Closed jiffyclub closed 9 years ago

jiffyclub commented 9 years ago

ActivitySim needs to read OMX files. Based on feedback from the community we'd like to have OMX available as a standalone Python library installable via pip and conda (on PyPI and binstar, respectively). This kind of release is required so we can easily install the OMX library for things like automated testing and so it can be listed as an explicit dependency of ActivitySim.

Related to making a release, I'd recommend splitting the directories for each OMX library into separate repositories. That's not strictly necessary, but it has some conveniences:

As an example, the official GitHub API wrappers for different languages are kept in separate repositories: https://github.com/octokit.

Whether you decide to split the the directories or not, I'm happy to help with the infrastructure for a release. We'll need this available soon for ActivitySim development and testing. (Though not until after the New Year.)

You may also be interested in the changes I made for the proposed integration of OMX with ActivitySim: https://github.com/synthicity/activitysim/pull/7. The changes included PEP8 compliance, switch to pytest for running unit tests, and additional test coverage.

jiffyclub commented 9 years ago

Just wanted to bump this. We'd like to get this available ASAP so we can rewrite existing ActivitySim PRs, merge them, and keep moving. cc @billyc Thanks!

danielsclint commented 9 years ago

@jiffyclub Can the stand alone library be created without splitting the project? If so, would you be willing to create a pull request to make this happen? I think it might help expedite the situation with the OMX team. Thanks.

bstabler commented 9 years ago

I think a phone call to discuss what you are doing and what your needs are would be helpful. After that, I'll engage the OMX community as needed. Thanks.

danielsclint commented 9 years ago

@bstabler Thanks. I got a note back that @billyc has this on his todo list. Hopefully, he can start on it after TRB. Perhaps the two of you could touch base to determine if he will need any help.

e-lo commented 9 years ago

@jiffyclub , I think @danielsclint question is still an open issue. My sense is also that we would need to split the libraries (which I am in favor of anyway) - but just wanted to make sure we had all the options on the table.

jiffyclub commented 9 years ago

This is workable whether it is decided to split the repo or keep everything together. But my recommendation is to create language-specific repositories (for the reasons above). I'm happy to make a PR once I know which direction to go. On Wed, Jan 14, 2015 at 5:42 PM Elizabeth Sall notifications@github.com wrote:

@jiffyclub https://github.com/jiffyclub , I think @danielsclint https://github.com/danielsclint question is still an open issue. My sense is also that we would need to split the libraries (which I am in favor of anyway) - but just wanted to make sure we had all the options on the table.

— Reply to this email directly or view it on GitHub https://github.com/osPlanning/omx/issues/13#issuecomment-70027056.

jiffyclub commented 9 years ago

Closing per https://github.com/synthicity/activitysim/issues/12#issuecomment-73619229.