I did a bit of work when going through the exercise of incorporating OMX into ActivitySim (synthicity/activitysim#7) and thought they might be appreciated here. The largest changes are increased test coverage and bug fixes.
Use temporary files and nosetests fixtures so that test files aren't left around in the working directory after running the unit tests
Several new tests covering previously untested parts of File
Fixed a bug in File.listAllAttributes that caused it to always return []
Use is/is not for comparisons to None so we don't get a warning from tables
I did a bit of work when going through the exercise of incorporating OMX into ActivitySim (synthicity/activitysim#7) and thought they might be appreciated here. The largest changes are increased test coverage and bug fixes.
File.listAllAttributes
that caused it to always return[]
is
/is not
for comparisons toNone
so we don't get a warning from tables