osPlanning / omx

Open Matrix (OMX)
https://github.com/osPlanning/omx/wiki
Apache License 2.0
49 stars 18 forks source link

Restructure CSharp API #20

Closed mmilkovits closed 8 years ago

mmilkovits commented 8 years ago

@Ennazus - I finally got my changes sorted out - I ended up moving a lot of stuff around, hope it all makes sense.

Unfortunately, I haven't been able to get read attributes from OMX file created by R-api. Can read from Cube converter just fine, but version and shape information are not coming through. Haven't tried reading a file from python or ruby, would be a good next step. This code throws a NotImplemented exception when it finds attributes of a type it can't handle - non-string versions and non-int shape.

mmilkovits commented 8 years ago

and thanks to @gvaio for the tips on the static class stucture

Ennazus commented 8 years ago

Hi Marty, Your changes have been merged. Thanks for pitching in to effort!! These all sound like great improvements! Also hi @gvaio! :)

bstabler commented 8 years ago

thanks!