search

osPrims / chatApp

A chatroom based web application built using Express.js and Socket.IO
https://chatapp-wuhy.onrender.com/
MIT License
22 stars 52 forks source link

Remove Welcome Voice and Notification #161

Closed PrimalPimmy closed 1 year ago

PrimalPimmy commented 2 years ago

We need to remove the "Welcome to chatApp, Instant messaging at your service" voice, since it is not necessary. This also includes the notification sounds. Remove any code belonging to this feature, including the mp3 files.

Check out this function here, and other similar functions in client.js , and remove any code that plays sound. https://github.com/osPrims/chatApp/blob/f612192999d6722bff509b055eaaf8a829e0dd00/public/client.js#L126

There are some more instances of playSound() here.

KossakowskaKarolina commented 2 years ago

Hello, I would work on this issue.

PrimalPimmy commented 2 years ago

Hi @KossakowskaKarolina , we're reserving all good first issues for absolute beginners, who have little to no experience in web dev. You can checkout our other non goodfirstissues :D

KossakowskaKarolina commented 2 years ago

Hi @PrimalPimmy, as a matter of fact I am absolute beginner with zero experience who is trying to learn on real-life examples. But if you say so, I'll take a look at different issue.

PrimalPimmy commented 2 years ago

I just looked at your profile and you have a really good profile, I wouldn't consider it absolute beginner, even if you are a beginner :) .All goodfirstissues are easy to do, so we are making sure only people who are new, to have a chance at this. Hope you understand.

KossakowskaKarolina commented 2 years ago

I absolutely understand, that's why I've been looking for that kind of issues :) Trying to do my first contibution. I'll give another one a try.

PrimalPimmy commented 2 years ago

The other issues might not be that tough, for example a good dark mode UI would be nice to have :D

MohitSinghChauhan commented 2 years ago

I want to work on this, Assign it to me :)

osBins commented 2 years ago

Appreciate your interest in wanting to contribute @MohitSinghChauhan! However we are reserving this issue for newcomers in our university. Please feel free to take a look at the other issues, and pick one which you feel is challenging enough for you to work on! Thank you for understanding.

Ocidemus commented 1 year ago

Hello I would like to work on this kindly assign it to me

PrimalPimmy commented 1 year ago

Hey @Ocidemus , thanks for showing interest in this, assigning this to you!