search

osa-eg / laravel-teams-notification

MIT License
9 stars 2 forks source link

#2 Update TeamsLoggerHandler #3

Closed devNoiseConsulting closed 2 months ago

devNoiseConsulting commented 2 months ago

Add this property definition for $teamsNotification to the class.

This prevents a "DEPRECATED Creation of dynamic property..." warning.

devNoiseConsulting commented 2 months ago

This should fix the warning in issue #2

osa-eg commented 2 months ago

Hello Michael,

Thank you for your contribution, I really appreciate it.

Your PR is approved, please make sure to run: composer update, to update the package in your app

Kind regards, Osama

On Thu, 5 Sept 2024, 11:21 pm Michael Flynn, @.***> wrote:

This should fix the warning in issue #2 https://github.com/osa-eg/laravel-teams-notification/issues/2

— Reply to this email directly, view it on GitHub https://github.com/osa-eg/laravel-teams-notification/pull/3#issuecomment-2332564774, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASHGDO677DIPA5SCYIVM4KTZVC4ONAVCNFSM6AAAAABNXHPVBGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZSGU3DINZXGQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>