search

osa1 / tiny

A terminal IRC client
MIT License
1.01k stars 60 forks source link

Weird Highlighting #434

Open znschaffer opened 1 month ago

znschaffer commented 1 month ago

my nick is znschaffer yet tiny keeps on highlighting YouTube links bizarrely.

image

I'm not sure what in the regex for nick's would cause this but it's mighty annoying

osa1 commented 1 month ago

This is probably an IRC color code to show the "Tube" part in red background, similar to the old logos here: https://logos-world.net/youtube-logo/ (scroll to "Meaning and History").

It looks like either the colored part is not terminated, or it is terminated but we don't handle the termination code properly.

Have you checked if these messages look as expected in other clients?

Which server/channel is this? Maybe I (or someone else) can join and debug this.

osa1 commented 1 month ago

@znschaffer could you try #435 and let me know if it fixes the issue?

znschaffer commented 1 month ago

oh my! i never would've thought it was added in w/ escape codes to replicate the old logomark. trying this patch now

znschaffer commented 1 month ago
image

cheers! @osa1

osa1 commented 1 month ago

That's better, but it still doesn't look right. The part after "Tube" looks bold now. Is this expected? Is it how it looks like in other clients?