search

osaddon / cdmi

CDMI on OpenStack Swift implementation
Apache License 2.0
22 stars 9 forks source link

First shot on deploying CDMI as python egg for OpenStack #1

Closed tmetsch closed 12 years ago

tmetsch commented 12 years ago

Hi,

Things I did:

I moved the code a but around to resolve a name clash in the hierarchy ot the packages. Added an setup.py file with an entry point for the WSGI app Made sure it compiles, it installs and starts according to the instructions in the README file Added a README Cheers,

-Thijs

osaddon commented 12 years ago

Thijs,     I am not familiar with the setup tool so I can not really comment on the changes. With these changes, I can not simply tar -xzvf the files into the swift directory. is there any way at all not to change the directory structure and still be able to use the setup tool?  The current structure actually including all the test and document follow swift file structures.

Thanks.

Tong.

From: tmetsch reply@reply.github.com To: osaddon email4tong@yahoo.com Sent: Monday, July 9, 2012 1:57 PM Subject: [cdmi] First shot on deploying CDMI as python egg for OpenStack (#1)

Hi,

Things I did:

I moved the code a but around to resolve a name clash in the hierarchy ot the packages. Added an setup.py file with an entry point for the WSGI app Made sure it compiles, it installs and starts according to the instructions in the README file Added a README Cheers,

-Thijs

You can merge this Pull Request by running:

  git pull https://github.com/tmetsch/cdmi-1 master

Or you can view, comment on it, or merge it online at:

  https://github.com/osaddon/cdmi/pull/1

-- Commit Summary --

  • moved and refacorted code

-- File Changes --

A .gitignore (29) A README.md (31) A cdmi/init.py (20) R cdmi/cdmi.py (10) A cdmi/cdmiapp/init.py (0) A cdmi/cdmiapp/cdmibase.py (0) R cdmi/cdmiapp/cdmicommoncontroller.py (4) R cdmi/cdmiapp/cdmicontrollers.py (6) R cdmi/cdmiapp/cdmiutils.py (2) R cdmi/cdmiapp/noncdmicontrollers.py (6) A setup.py (32)

-- Patch Links --

  https://github.com/osaddon/cdmi/pull/1.patch   https://github.com/osaddon/cdmi/pull/1.diff

Reply to this email directly or view it on GitHub: https://github.com/osaddon/cdmi/pull/1

tmetsch commented 12 years ago

Hi,

So the advantages when using the setuptool are the following:

This in contrast to manually copying the file to a development swift installtion. Think about people who have installed OpenStack using apt's or similar. The setup using setuptools is way easier that way.

Integration with Swift is also very easy. You only need to configure swift and no longer fiddle in the source directories.

Using the same directory structure as in swift will actually break swift. Because there is a name clash than.

We will get the test back up and running asap - no worries I'll help there if you like.

Hope this helps,

-Thijs

osaddon commented 12 years ago

Thijs,     OK, let me do an update so that the changes will be reflected in the repository. BTW, can not access https://github.com/tmetsch/cdmi-1, it shows a 404 error. Thanks. Tong.

From: tmetsch reply@reply.github.com To: osaddon email4tong@yahoo.com Sent: Monday, July 9, 2012 3:32 PM Subject: Re: [cdmi] First shot on deploying CDMI as python egg for OpenStack (#1)

Hi,

So the advantages when using the setuptool are the following:

  • User can install it using known Methods for Python python setup.py install
  • Later when deployed in pypi (pypi.python.org) people could use easy_install cdmi or pip install cdmi to install cdmi and all it's dependencies out of the box - it is the same mechanism OpenStack uses.
  • It'll make deployment using chef and puppet extremly simple
  • It is extremly easy to delveop using devstack

This in contrast to manually copying the file to a development swift installtion. Think about people who have installed OpenStack using apt's or similar. The setup using setuptools is way easier that way.

Integration with Swift is also very easy. You only need to configure swift and no longer fiddle in the source directories.

Using the same directory structure as in swift will actually break swift. Because there is a name clash than.

We will get the test back up and running asap - no worries I'll help there if you like.

Hope this helps,

-Thijs

Reply to this email directly or view it on GitHub: https://github.com/osaddon/cdmi/pull/1#issuecomment-6857059

tmetsch commented 12 years ago

Ah sorry I moved my repository to https://github.com/tmetsch/cdmi I initially forked your other cdmi repository!

Cheers,

-Thijs

osaddon commented 12 years ago

How can I easily get your updates merged into my cdmi? I can see there is a pull? Thanks. Tong.

From: tmetsch reply@reply.github.com To: osaddon email4tong@yahoo.com Sent: Monday, July 9, 2012 3:54 PM Subject: Re: [cdmi] First shot on deploying CDMI as python egg for OpenStack (#1)

Ah sorry I moved my repository to https://github.com/tmetsch/cdmi I initially forked your other cdmi repository!

Cheers,

-Thijs

Reply to this email directly or view it on GitHub: https://github.com/osaddon/cdmi/pull/1#issuecomment-6857634

tmetsch commented 12 years ago

There is asection on dealing with pull request in this document: https://help.github.com/articles/using-pull-requests

Hope that helps - otherwise we can sync tomorrow!

Cheers,

-Thijs

tmetsch commented 12 years ago

Updated the pull request. Unit tests run again now - had to update them a bit since the swift client lib was moved to an own project since march.

All seems to be running smoothly now!

Cheers,

-Thijs

osaddon commented 12 years ago

Great.

Sent from my iPhone

On Jul 10, 2012, at 5:00 AM, tmetsch reply@reply.github.com wrote:

Updated the pull request. Unit tests run again now - had to update them a bit since the swift client lib was moved to an own project since march.

All seems to be running smoothly now!

Cheers,

-Thijs

Reply to this email directly or view it on GitHub: https://github.com/osaddon/cdmi/pull/1#issuecomment-6870303