search

osalabs / osafw-php

Business Applications Web Framework, PHP
MIT License
3 stars 3 forks source link

sidebar.html: 'access_level' blocks #13

Closed vladsavchuk closed 5 years ago

vladsavchuk commented 6 years ago

Suggest changing ifgt to ifge in sidebar.html:

old

<~admin80_menu ifgt="SESSION[access_level]" value="80" inline>

new

<~admin80_menu ifge="SESSION[access_level]" value="80" inline>

Because it's natural to count by tens. Consider the following:

Value Category
100 Admin
90 Supervisor
80 Manger

To display manager menu, I have to <~admin80_menu ifgt="SESSION[access_level]" value="79" inline>

that doesn't align with having access_level value of 80 in tag name <~admin80 and comparison value of 79.

osalabs commented 5 years ago

Fixed some time ago