search

osalabs / osafw-php

Business Applications Web Framework, PHP
MIT License
3 stars 3 forks source link

Update Users.php #35

Closed vladsavchuk closed 5 years ago

vladsavchuk commented 6 years ago

"addOrUpdate" seems obsolete.

this "add" overriding implementation cause the password to encrypt 2 times in case of new user creation - it's already encrypted in AdminUsersController.

osalabs commented 6 years ago

OK, addOrUpdate is not used and can be removed. However add has one more function - it sets password to random is password not set, so it's still necessary (however you could remove pwd encryption from it)