osam-cologne / archlinux-proaudio

Actively maintained binary package repo for Arch Linux of free and open source pro-audio software.
https://arch.osamc.de/
The Unlicense
42 stars 2 forks source link

uhhyou-plugins PKGBUILD moduleinfo.json #241

Closed elder-n00b closed 1 year ago

elder-n00b commented 1 year ago
install: cannot stat 'adelay.vst3/Contents/moduleinfo.json': No such file or directory
==> ERROR: A failure occurred in package().
    Aborting...
error: failed to build 'uhhyou-plugins-0.55.0-1':
error: packages failed to build: uhhyou-plugins-0.55.0-1

moduleinfo.json files are in $plugin/Contents/Resources

(commenting here because https://aur.archlinux.org/packages/uhhyou-plugins#comment-895977)

SpotlightKid commented 1 year ago

There is no plugin called adelay.vst3 in this package. The package builds without problems here. Please try building with a clean build dir (i.e. remove any old pkg and src dirs).

elder-n00b commented 1 year ago

https://github.com/osam-cologne/archlinux-proaudio/blob/a2f04c6541b317376d4d9b88e1fc9c5f09882290/packages/uhhyou-plugins/PKGBUILD#L66 I did paru -S uhhyou-plugins on an up to date system and got that. I'll try again later, I'm pretty sure it's just two /Resources away.

edit: Looks like adelay comes from the vst3sdk... will check that later.

SpotlightKid commented 1 year ago
$ makepkg
$ cd src/build/VST3/Release
$ ls -l *.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1160 07.06.2023 15:12 AccumulativeRingMod.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1165 07.06.2023 15:12 BasicLimiterAutoMake.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1141 07.06.2023 15:12 BasicLimiter.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1141 07.06.2023 15:12 ClangCymbal.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1136 07.06.2023 15:12 ClangSynth.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1164 07.06.2023 15:12 CollidingCombSynth.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1145 07.06.2023 15:12 CombDistortion.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1149 07.06.2023 15:12 CubicPadSynth.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1149 07.06.2023 15:12 EnvelopedSine.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1131 07.06.2023 15:12 EsPhaser.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1136 07.06.2023 15:12 FDN64Reverb.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1140 07.06.2023 15:12 FDNCymbal.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1145 07.06.2023 15:12 FeedbackPhaser.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris  991 07.06.2023 15:12 FoldShaper.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1167 07.06.2023 15:12 IterativeSinCluster.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1127 07.06.2023 15:12 L3Reverb.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1127 07.06.2023 15:12 L4Reverb.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1142 07.06.2023 15:12 LatticeReverb.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1149 07.06.2023 15:13 LightPadSynth.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1133 07.06.2023 15:12 LongPhaser.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1146 07.06.2023 15:12 MatrixShifter.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1136 07.06.2023 15:13 MaybeSnare.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1145 07.06.2023 15:13 MembraneSynth.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1132 07.06.2023 15:13 MiniCliffEQ.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1143 07.06.2023 15:13 ModuloShaper.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1140 07.06.2023 15:13 NarrowingDelay.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1143 07.06.2023 15:13 OddPowShaper.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1145 07.06.2023 15:13 OrdinaryPhaser.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1138 07.06.2023 15:13 ParallelComb.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1146 07.06.2023 15:13 ParallelDetune.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1149 07.06.2023 15:13 PitchShiftDelay.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1140 07.06.2023 15:13 RingModSpacer.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1132 07.06.2023 15:13 SevenDelay.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1140 07.06.2023 15:13 SoftClipper.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1146 07.06.2023 15:13 SyncSawSynth.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1152 07.06.2023 15:13 TrapezoidSynth.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1156 07.06.2023 15:13 UltrasonicRingMod.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1138 07.06.2023 15:13 UltraSynth.vst3/Contents/moduleinfo.json
-rw-r--r-- 1 chris chris 1137 07.06.2023 15:13 WaveCymbal.vst3/Contents/moduleinfo.json
cbix commented 1 year ago

The build error happens due to breaking changes in (of course ...) vst3sdk 3.7.8. Still need to figure out what's the new flag to disable building sample plugins but I put a hacky workaround in #242, if that builds I'll merge and a bit later the AUR should be updated.

elder-n00b commented 1 year ago

Thanks @cbix, I'll test that soon. Just in case it's still useful I post this stuff below (was going to post earlier but life gets in the way sometimes LOL):

I guess I'm in for an epic facepalm, anyway this is it: I first cleaned up with `sudo pacman -R vst3sdk` and `rm -rf ~/.cache/paru/clone/uhhyou-plugins/`, then (instead of using `paru` as before) cloned https://aur.archlinux.org/uhhyou-plugins.git and run `pkgbuild`. Of course it failed with missing dependency `vst3sdk` so I then used `pkgbuild -s` which proceeded to install it again (successfully, `vst3sdk 3.7.8_build_34-1`) and then failed the same way: ~~~ ==> Retrieving sources... -> Downloading uhhyou-plugins-0.55.0.tar.gz... ... ==> Entering fakeroot environment... ==> Starting package()... install: creating directory '/.mnt/data/.share/Projects/main/uhhyou-plugins.PKGBUILD/pkg/uhhyou-plugins/usr' install: creating directory '/.mnt/data/.share/Projects/main/uhhyou-plugins.PKGBUILD/pkg/uhhyou-plugins/usr/lib' install: creating directory '/.mnt/data/.share/Projects/main/uhhyou-plugins.PKGBUILD/pkg/uhhyou-plugins/usr/lib/vst3' install: creating directory '/.mnt/data/.share/Projects/main/uhhyou-plugins.PKGBUILD/pkg/uhhyou-plugins/usr/lib/vst3/adelay.vst3' install: creating directory '/.mnt/data/.share/Projects/main/uhhyou-plugins.PKGBUILD/pkg/uhhyou-plugins/usr/lib/vst3/adelay.vst3/Contents' install: creating directory '/.mnt/data/.share/Projects/main/uhhyou-plugins.PKGBUILD/pkg/uhhyou-plugins/usr/lib/vst3/adelay.vst3/Contents/x86_64-linux' 'adelay.vst3/Contents/x86_64-linux/adelay.so' -> '/.mnt/data/.share/Projects/main/uhhyou-plugins.PKGBUILD/pkg/uhhyou-plugins/usr/lib/vst3/adelay.vst3/Contents/x86_64-linux/adelay.so' install: cannot stat 'adelay.vst3/Contents/moduleinfo.json': No such file or directory ==> ERROR: A failure occurred in package(). Aborting... ~~~ Then I changed the PKGBUILD as this: ~~~ @@ -66 +66 @@ - install -vDm644 $plugin/Contents/moduleinfo.json -t "$pkgdir"/usr/lib/vst3/$plugin/Contents + install -vDm644 $plugin/Contents/Resources/moduleinfo.json -t "$pkgdir"/usr/lib/vst3/$plugin/Contents/Resources ~~~ and this time it built the package. BUT, then I checked `src/build/VST3/Release`: ~~~ adelay.vst3 again-sampleaccurate.vst3 againsimple.vst3 again.vst3 channelcontext.vst3 hostchecker.vst3 legacymidiccout.vst3 mda-vst3.vst3 multiple-program-changes.vst3 noteexpressionsynth.vst3 noteexpressiontext.vst3 panner.vst3 pitchnames.vst3 prefetchable.vst3 programchange.vst3 syncdelay.vst3 ~~~ and those are from the sdk not the uhhyou stuff... I don't understand. Well, one thing it does mean: I was wrong. I did not even find the uhhyou ones anywhere actually: ~~~ fish❯ fd -gHI '*AccumulativeRingMod*' src/VSTPlugins-UhhyouPlugins0.55.0/AccumulativeRingMod/ src/VSTPlugins-UhhyouPlugins0.55.0/presets/json/AccumulativeRingMod.type.json src/VSTPlugins-UhhyouPlugins0.55.0/presets/json/AccumulativeRingMod.preset.json src/VSTPlugins-UhhyouPlugins0.55.0/presets/Uhhyou/AccumulativeRingMod/ src/VSTPlugins-UhhyouPlugins0.55.0/docs/manual/AccumulativeRingMod/ src/VSTPlugins-UhhyouPlugins0.55.0/docs/manual/AccumulativeRingMod/AccumulativeRingMod.json src/VSTPlugins-UhhyouPlugins0.55.0/docs/manual/AccumulativeRingMod/img/AccumulativeRingMod.odg src/VSTPlugins-UhhyouPlugins0.55.0/docs/manual/AccumulativeRingMod/img/AccumulativeRingMod.png src/VSTPlugins-UhhyouPlugins0.55.0/docs/manual/AccumulativeRingMod/img/AccumulativeRingMod.svg src/VSTPlugins-UhhyouPlugins0.55.0/docs/manual/AccumulativeRingMod/AccumulativeRingMod_ja.html src/VSTPlugins-UhhyouPlugins0.55.0/docs/manual/AccumulativeRingMod/AccumulativeRingMod_en.html src/VSTPlugins-UhhyouPlugins0.55.0/docs/manual/AccumulativeRingMod/AccumulativeRingMod_ja.md src/VSTPlugins-UhhyouPlugins0.55.0/docs/manual/AccumulativeRingMod/AccumulativeRingMod_en.md pkg/uhhyou-plugins/usr/share/doc/uhhyou-plugins/manual/AccumulativeRingMod/ pkg/uhhyou-plugins/usr/share/doc/uhhyou-plugins/manual/AccumulativeRingMod/img/AccumulativeRingMod.png pkg/uhhyou-plugins/usr/share/doc/uhhyou-plugins/manual/AccumulativeRingMod/img/AccumulativeRingMod.svg pkg/uhhyou-plugins/usr/share/doc/uhhyou-plugins/manual/AccumulativeRingMod/AccumulativeRingMod_ja.html pkg/uhhyou-plugins/usr/share/doc/uhhyou-plugins/manual/AccumulativeRingMod/AccumulativeRingMod_en.html fish❯ fd -gHI '*.vst3' pkg/uhhyou-plugins/usr/lib/vst3/noteexpressiontext.vst3/ pkg/uhhyou-plugins/usr/lib/vst3/adelay.vst3/ src/build/VST3/Release/noteexpressiontext.vst3/ src/build/VST3/Release/adelay.vst3/ src/build/VST3/Release/multiple-program-changes.vst3/ src/build/VST3/Release/hostchecker.vst3/ src/build/VST3/Release/againsimple.vst3/ src/build/VST3/Release/noteexpressionsynth.vst3/ src/build/VST3/Release/panner.vst3/ src/build/VST3/Release/legacymidiccout.vst3/ src/build/VST3/Release/pitchnames.vst3/ src/build/VST3/Release/syncdelay.vst3/ src/build/VST3/Release/mda-vst3.vst3/ src/build/VST3/Release/again.vst3/ src/build/VST3/Release/channelcontext.vst3/ src/build/VST3/Release/again-sampleaccurate.vst3/ src/build/VST3/Release/programchange.vst3/ src/build/VST3/Release/prefetchable.vst3/ pkg/uhhyou-plugins/usr/lib/vst3/multiple-program-changes.vst3/ pkg/uhhyou-plugins/usr/lib/vst3/hostchecker.vst3/ pkg/uhhyou-plugins/usr/lib/vst3/againsimple.vst3/ pkg/uhhyou-plugins/usr/lib/vst3/noteexpressionsynth.vst3/ pkg/uhhyou-plugins/usr/lib/vst3/panner.vst3/ pkg/uhhyou-plugins/usr/lib/vst3/legacymidiccout.vst3/ pkg/uhhyou-plugins/usr/lib/vst3/pitchnames.vst3/ pkg/uhhyou-plugins/usr/lib/vst3/syncdelay.vst3/ pkg/uhhyou-plugins/usr/lib/vst3/mda-vst3.vst3/ pkg/uhhyou-plugins/usr/lib/vst3/again.vst3/ pkg/uhhyou-plugins/usr/lib/vst3/channelcontext.vst3/ pkg/uhhyou-plugins/usr/lib/vst3/again-sampleaccurate.vst3/ pkg/uhhyou-plugins/usr/lib/vst3/programchange.vst3/ pkg/uhhyou-plugins/usr/lib/vst3/prefetchable.vst3/ ~~~ I was going to try again with the PKGBUILD from `../archlinux-proaudio/packages/uhhyou-plugins/PKGBUILD` (where I cloned this repo) but they're identical.

Anyways, the above is likely irrelevant now. I'll do again with the #242 fix and report when it's done compiling.

I found https://steinbergmedia.github.io/vst3_dev_portal/pages/Technical+Documentation/VST+Module+Architecture/ModuleInfo-JSON.html which says

This optional moduleinfo.json file was added in the VST 3 SDK version 3.7.5 and was located in the Contents folder of the bundle. In order to be compliant with code signing on macOS, this file is now (since version 3.7.8) located in the Contents/Resources folder.

and that explains at least part of the trouble, but why can't I find the built uhhyou plugins along with the examples?

elder-n00b commented 1 year ago

Apologies for long delay... here comes the facepalm: no AVX no party.

SpotlightKid commented 1 year ago

Maybe worth an upstream ticket. Compilation should error out if the CPU is not supported instead of silently not building the plugins. IMO.

cbix commented 1 year ago

Ah damn, they're really not building, sorry for that! Trying to fix it now ...

cbix commented 1 year ago

Needs some further attention later, but I opened ryukau/VSTPlugins#38 now

SpotlightKid commented 1 year ago

The package for version 0.56.0 built by CI does still not contain the plugins, only the documentation. Builds fine locally on Manjaro, but therevst3sdk is still at version 3.7.7_build_19-1.