Open nandorojo opened 2 years ago
The issue is node-vibrant. I added that to the snack. It gets the pallet differently on mobile and desktop browsers. Not sure what could cause that.
I opened an issue on node-vibrant: https://github.com/Vibrant-Colors/node-vibrant/issues/132
I ultimately decided to call the function from a server to always get consistent results. Bummer cause it's slower, but it works that way.
I do wish to explore if this library could be re-written to wrap another C++ library for image color extraction using JSI and WASM for web. I think this is the last resort to unify results for all platforms. Just need to find the time since I have no experience with all of that and would have to explore if its doable.
Bug
Mobile browsers and desktop browsers return a different set of colors for the same image. I'm not sure if this is a bug with
node-vibrant
or this library's Web approach. My guess is it's node vibrant?Take this image:
On a desktop browser, I get these colors, which seem relatively correct. They're essentially grays.
However, on a mobile browser (Chrome or Safari on iOS), I get these colors:
Environment info
Steps To Reproduce
Describe what you expected to happen:
Reproducible sample code
Here is a reproducible snack: https://snack.expo.dev/@beatgig/thankful-almond?supportedPlatforms=web
These are the colors it comes up with on a desktop browser:
Meanwhile, here it is on a mobile browser (you'll have to turn your phone sideways to see it on Snack)