search

osamu620 / OpenHTJ2K

An open source implementation of ITU-T Rec.814 | ISO 15444-15 (a.k.a. HTJ2K).
BSD 3-Clause "New" or "Revised" License
36 stars 10 forks source link

Add installation to CMake #154

Closed jubalh closed 11 months ago

jubalh commented 11 months ago

I see the installation part is still commented out: https://github.com/osamu620/OpenHTJ2K/blob/main/CMakeLists.txt#L169 The README also so far mentions just the build process and no install. So I assume this is intentionally not ready yet :)

I just wanted to open this issue to keep track of this that I can get notified when it's ready.

I started to create a test package for openSUSE in my home repo. Just to experiment with it and later once everything is ready push it to the main distribution.

osamu620 commented 11 months ago

Hi @jubalh , thanks for raising this issue. Because I'm unfamiliar with packaging stuff with CMake, yes, it has been intentionally commented out.

Your suggestion and/or knowledge are more than welcome :)

jubalh commented 11 months ago

I will set put it on my TODO to check this :) Don't know quite yet when I will find the time.

osamu620 commented 11 months ago

FYI - I have filled the installation part (fe70b1b1879e59eac499ca323e07bd732245b65e).

jubalh commented 11 months ago

Great! Thanks! I updated the package and it builds and install fine. I noticed that the imgcmp binary isn't installed. Is this intentional?

osamu620 commented 11 months ago

@jubalh Yes, imgcmp is just a tool for conformance testing. I think tools like compare in ImageMagick are much more universal. Make sense?

jubalh commented 11 months ago

Perfect :)