search

osamuaoki / inputmethod-shortcuts

Quick switching of input method and touchpad (GNOME)
https://extensions.gnome.org/extension/6066/shortcuts-to-activate-input-methods/
GNU General Public License v2.0
15 stars 1 forks source link

Error: No property use_markup on AdwActionRow #5

Closed anatoli26 closed 1 year ago

anatoli26 commented 1 year ago

Hi,

After enabling the extension on UIbuntu 22.04 (Gnome 42.9), I get the following error:

Error: No property use_markup on AdwActionRow

Stack trace:
  _init/Gtk.Widget.prototype._init@resource:///org/gnome/gjs/modules/core/overrides/Gtk.js:55:50
  addShortcutPage@/home/user/.local/share/gnome-shell/extensions/inputmethod-shortcuts@osamu.debian.org/prefs.js:71:18
  fillPreferencesWindow@/home/user/.local/share/gnome-shell/extensions/inputmethod-shortcuts@osamu.debian.org/prefs.js:42:20
  _init@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:27:29
  ExtensionPrefsDialog@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:10:4
  OpenExtensionPrefsAsync/<@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:129:33
  asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:115:22
  run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:186:20
  main@resource:///org/gnome/Shell/Extensions/js/main.js:22:13
  run@resource:///org/gnome/gjs/modules/script/package.js:206:19
  start@resource:///org/gnome/gjs/modules/script/package.js:190:8
  @/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17
osamuaoki commented 1 year ago

I realize I need to drop use_markup to support GNOME42.

Please save all your work and open a terminal to clone and checkout "backport" branch:

$ git clone -b backport https://github.com/osamuaoki/inputmethod-shortcuts.git
$ cd inputmethod-shortcuts
$ make install
$ killall gnome-shell
... restart with login

Does this fix?

I am asking proper way to upload for GNOME version depended package offering to GNOME extension site.

anatoli26 commented 1 year ago

Yes, it's working great now! Thanks for fixing!

osamuaoki commented 1 year ago

Great.

Uploaded fixed one to e.g.o but there was some issue.. (Short interval of following upload of 43-44 version caused fixed version targeting 40-42 to be rejected automatically.)

Please note it doesn't look as nice because of lack of markups.

osamuaoki commented 1 year ago

FYI: There are some minor refining to expand shortcut key offerings, in progress.

osamuaoki commented 1 year ago

e.g.o upload issue was manually resolved. Now anyone can install from there.