osarrouy / robinhoodcoop

1 stars 5 forks source link

please document any state inside the code #26

Closed whysthatso closed 4 years ago

whysthatso commented 4 years ago

skimming through the code i see a lot of references to ether-addresses that are looking like magic numbers. there are also references to accounts, key constants, regexes without matching examples, etc.

please extract them out into a commented configuration file, or at the least gather them in the readme / handover document.

whysthatso commented 4 years ago

done