search

osarrouy / robinhoodcoop

1 stars 5 forks source link

please check phone number verification #32

Closed whysthatso closed 3 years ago

whysthatso commented 3 years ago

we have a member complaining that entering valid phone numbers is not accepted by the form, see screenshot example

Screenshot 2020-09-16 at 04 02 07 AM

can you have a look, and possibly make the verification more forgiving?

whysthatso commented 3 years ago

another member confirmed my suspicion:

I immediately wanted to sign up but came across an issue: my telephone number seems to be too long, according to the signup form (I checked the validation regex code of the signup form and it seems that the maximum accepted length of a phone number is 13 digits including the country code, area code and subscriber number, but international standard should be 15 digits ); should be an easy and quick fix for the programmer.

whysthatso commented 3 years ago

i would even leave this number to be higher, no need to be that strict.

whysthatso commented 3 years ago

reopen for review

osarrouy commented 3 years ago

Your fix all looks good to me. You didn't have any issue since ?

osarrouy commented 3 years ago

Looks good so closing it.