search

osate / ErrorModelV2

Old AADL EMV2 annex repository, kept for reference
3 stars 10 forks source link

FTA Report - When occurrence distribution is fixed don't use default value #72

Closed fletchwsf closed 6 years ago

fletchwsf commented 9 years ago

The current output of the FTA report generator is understood by Open FTA, but the report substitutes a default value instead of the user provided value. If the AADL model specifies a fixed distribution, the report generator should use this value rather than the default value. Note, the aaxl2 file has the correct rate value, but it is not clear if current version of the aaxl2 value includes a value for the distribution type (fixed, poisson, etc).

EMV2 { ... properties EMV2::OccurrenceDistribution => [ProbabilityValue => 0.3; Distribution => fixed;] applies to Failure; ... }

juli1 commented 9 years ago

Hello,

Would it be possible to provide a model example? The code is already in place to get the probability value for error events and on my side, works correctly. The default value (0.1) has been added because when leaving 0.0, it could create some issue when computing probabilities in OpenFTA (with divide by zero issues). However, if you associate a probability value to the event, it should be ok. Please send a complete model so that we can reproduce the issue.

fletchwsf commented 9 years ago

Hi Julien,

Thanks for getting back to me so quickly, I was expecting a couple of days delay after the end of the meeting in Spain.

The model is question has been posted to gitHub, see Fault_tree_3.aadl.

https://github.com/fletch787/OSATE-FTA-Tests.git

Update URL for the example model https://github.com/fletchwsf/OSATE-FTA-Tests.git On Fri, Oct 3, 2014 at 9:12 AM, Julien notifications@github.com wrote:

Hello,

Would it be possible to provide a model example? The code is already in place to get the probability value for error events and on my side, works correctly. The default value (0.1) has been added because when leaving 0.0, it could create some issue when computing probabilities in OpenFTA (with divide by zero issues). However, if you associate a probability value to the event, it should be ok. Please send a complete model so that we can reproduce the issue.

— Reply to this email directly or view it on GitHub https://github.com/osate/ErrorModelV2/issues/72#issuecomment-57794405.

juli1 commented 9 years ago

In fact, the property is correctly processed if associated with an error type (for example by using applies to failure.serviceOmission or something similar. Will investigate why it does not work when not specifying the error type, I have to discuss that with Peter.

reteprelief commented 6 years ago

Resolved. We do not use OpenFTA anymore.